Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For loop support in alg codegen #174

Merged
merged 3 commits into from
Jan 14, 2023
Merged

For loop support in alg codegen #174

merged 3 commits into from
Jan 14, 2023

Conversation

ZibingZhang
Copy link
Contributor

@ZibingZhang ZibingZhang commented Jan 13, 2023 •
edited
Loading

Overview

For loop support for algorithmic codegen.

Details

Added visit_For methods in algorithmic_codegen.py.

Decided to choose \in as the way to indicate iteration through the iterable, e.g. FOR x \in {1, 2, 3}. Unsure if this is desired.

References

Described by #57
Requested in #170 (comment)

Blocked by

None

@ZibingZhang ZibingZhang requested a review from odashi as a code owner January 13, 2023 03:51
odashi
odashi approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@odashi odashi merged commit b3ae7fa into google:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi odashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibingZhang @odashi