[FIX] Issue #202 and #190 #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quetzyg
commented
Apr 5, 2021
| @@ -303,7 +303,7 @@ func TestUnmarshalSetsID(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| if out.ID != 2 { | |||
| if out.ID != 9223372036854775807 { | |||
There was a problem hiding this comment.
If we used this value previously, the test would fail;
|
@aren55555 lmk what you think. |
quetzyg
commented
Apr 5, 2021
| @@ -495,27 +498,26 @@ func handleTime(attribute interface{}, args []string, fieldValue reflect.Value) | |||
| return reflect.ValueOf(t), nil | |||
| } | |||
|
|
|||
| var at int64 | |||
| switch v.Interface().(type) { | |||
There was a problem hiding this comment.
The original logic was kept, since we're still checking the type of the attribute, while the previous/following checks are done to the fieldValue kind.
I wonder if we should check the fieldValue kind here as well for consistency.
quetzyg
commented
Apr 5, 2021
|
I'll take a look on Sunday when I'll actually be able to allocate enough time to dig into this. |
… the handleStruct() function
|
@aren55555 the work on this PR is done, do take a look. |
12 tasks
|
@aren55555 would be nice if you can merge according the dependency to #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to fix numeric precision when decoding, fixing issue #202 and potentially #190 and #120?
Task items:
UseNumber();handleNumeric()function);