-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handleStruct to use struct's own Unmarshaler if it is available #169
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Is there anything holding this back from getting merged? Worked for me with a custom struct holding a |
@mellena1 we've been using it for the past couple of months in production and it's working fine. Who's got the power to merge this? You can use my fork in the meanwhile. |
@michele I started using your fork last night and it’s working great for me so far. Thanks a lot for the work! Hopefully this can be merged in soon. The only other thing I think would be good to add to this PR would be some documentation in the README, but it definitely works intuitively without it. |
@shwoodard Hi, could you take a look at this or dispatch it to somebody else with access to this project? |
handleStruct
wasn't properly handling structs with custom marshaler/unmarshaler.With this PR
handleStruct
correctly handles structs which implement thejson.Unmarshaler
interface.This should fix #164