Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement source in error object #151

Closed
wants to merge 1 commit into from

Conversation

eraclitux
Copy link

Some applications (es. Emberjs) use source object in json api error to show messages returned from backend to users.
This PR extends ErrorObject to optionally include source object.
ref:
https://stackoverflow.com/questions/31918565/handling-errors-with-the-now-default-ember-data-json-api-adapter
http://jsonapi.org/format/#error-objects

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@eraclitux
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@eraclitux
Copy link
Author

I just discovered #134 😥

@eraclitux eraclitux closed this Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants