Implement error object links. #139
Conversation
* working version * fix text * combine test files * move private funcs to bottom * ErrInvalidType should ignore interfaces * replace MarshalOnePayload w/ MarshalPayload; fix bug w/ node merge() * minor tweaks; address a couple comments * decompose unmarshalNode() to smaller funcs; unmarshal should go from top-level to embedded * deep copy the node when passing relation/sideloaded notes to unmarshal() * add some comments and do some additional cleanup * add test uses annotationIgnore * implement support for struct fields that implement json.Marshaler/Unmarshaler * add additional test that compares marshal/unmarshal behavior w/ standard json library * add support for pointer embedded structs * Revert "implement support for struct fields that implement json.Marshaler/Unmarshaler" This reverts commit deeffb7.
…zation/deserilization.
…e primary annotation fields.
* fix TestEmbededStructs_nonNilStructPtr; bug on loop w/ (multiple) embedded structs; should just continue on success * fix TestMarshal_duplicatePrimaryAnnotationFromEmbeddedStructs; fix order of processing of visitModelNode
…ailing tests that are related to the handling of duplicate embedded struct fields.
…ere an Outer struct had an attr field and an embedded field provided a field with the same attr name.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
➕ I would like to see this implemented as well |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
See http://jsonapi.org/format/#error-objects.