Embeded structs fix tests part2 #108
Conversation
| } | ||
|
|
||
| for _, scenario := range tests { | ||
| t.Logf("scenario: %s\n", scenario.name) |
There was a problem hiding this comment.
Use t.Run. See "Table-driven tests using subtests" @ https://blog.golang.org/subtests
| // * adds new entries as-is | ||
| // * tracks dominant field conflicts | ||
| func (a attributes) set(k string, v interface{}) { | ||
| if val, ok := a[k]; ok { |
There was a problem hiding this comment.
rename ok to hasKey. Convention is to use ok for type assertion only.
| }) | ||
| } | ||
|
|
||
| func (n *Node) mergeFunc(node *Node, attrSetter func(attrs attributes)) { |
There was a problem hiding this comment.
move mergeFunc higher in the file as it used by methods before it is declared.
| } | ||
| } | ||
|
|
||
| // mergeAttributes consolidates multiple nodes into a single consolidated node |
There was a problem hiding this comment.
This comment doesn't seem to make sense here: seems to be for a different function.
| @@ -183,3 +239,36 @@ func deepCopyNode(n *Node) *Node { | |||
| } | |||
| return © | |||
| } | |||
|
|
|||
| // nodeError is used to track errors in processing Node related values | |||
| type nodeError interface { | |||
There was a problem hiding this comment.
Is there more than one of these things? Why do we need an interface?
| // dominantFieldConflict is a specific type of marshaling scenario that the standard json lib treats as an error | ||
| // comment from json.dominantField(): "If there are multiple top-level fields...This condition is an error in Go and we skip" | ||
| // tracking the key and conflicting values for future use to possibly surface an error | ||
| type dominantFieldConflict struct { |
There was a problem hiding this comment.
Rename embeddedStructFieldConflict
| var er error | ||
|
|
||
| modelValue := reflect.ValueOf(model).Elem() | ||
| modelType := reflect.ValueOf(model).Type().Elem() | ||
|
|
||
| node := new(Node) |
There was a problem hiding this comment.
Identify if is embedded and extract embedded extraction to own func
No description provided.