The service host limit should call the completion handler for stopFetching when enabled #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There's no direct way to tell a fetcher got delayed by the service per host limits, so just add some assertions and document it - Update the logic for the checks to match what will/won't get notifications and callbacks. - Better comment some of the tracking variables since they are tracking two different things (notifications vs callbacks).
dmaclach
previously approved these changes
Nov 18, 2024
No functional changes (aside from more `@synchronized` calls to update the state). Future changes will then be able to act on the state as needed.
Also update/enable tests to check/match this.
thomasvl
force-pushed
the
stopFetching_host_limit_delayed
branch
from
89ef20a to
a35d5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.