Add more tests around stopping fetchers with callbacks. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these cases are XCTSkipped as they reliable fail when run locally. This will be follow up work to fix them. These tests are likely to be racy since they are just using delays, but they do catch some fail cause already. Some could be made non racy if the authorizer delay and the stop ordering was perfectly synchronized, but that is likely to be a fair amount of complexity to ensure it is done correctly and non blocking; so it is deferred for now. I also haven't reasoned through why the Service versions currently all pass when the non service cases fail. That will get some attention during the followup to fix the existing failures.
thomasvl
force-pushed
the
more_cancel_tests
branch
from
6ba4c84 to
671ba9f
Compare
dmaclach
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these cases are XCTSkipped as they reliable fail when run locally. This will be follow up work to fix them.
These tests are likely to be racy since they are just using delays, but they do catch some fail cause already. Some could be made non racy if the authorizer delay and the stop ordering was perfectly synchronized, but that is likely to be a fair amount of complexity to ensure it is done correctly and non blocking; so it is deferred for now.
I also haven't reasoned through why the Service versions currently all pass when the non service cases fail. That will get some attention during the followup to fix the existing failures.