Skip to content

Commit

Permalink
Improve Maven plugin configuration (#2775)
Browse files Browse the repository at this point in the history
- Explicitly specifies `org.apache.maven.plugins` group ID
- Removes redundant `maven-failsafe-plugin` version in `test-shrinker` module
  This is inherited from the parent POM
- Adds required Error Prone compiler arg, see https://github.com/google/error-prone/releases/tag/v2.34.0
  • Loading branch information
Marcono1234 authored Nov 7, 2024
1 parent 04f66f9 commit 78caa5e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions gson/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.3.1</version>
<executions>
Expand Down
2 changes: 2 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@
<compilerArgs>
<!-- Args related to Error Prone, see: https://errorprone.info/docs/installation#maven -->
<arg>-XDcompilePolicy=simple</arg>
<arg>--should-stop=ifError=FLOW</arg>
<arg>-Xplugin:ErrorProne
-XepExcludedPaths:.*/generated-test-sources/protobuf/.*
-Xep:NotJavadoc:OFF <!-- Triggered by local class. -->
Expand Down Expand Up @@ -403,6 +404,7 @@
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>3.1.0</version>
<executions>
Expand Down
1 change: 0 additions & 1 deletion test-shrinker/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.5.1</version>
<executions>
<execution>
<goals>
Expand Down

0 comments on commit 78caa5e

Please sign in to comment.