feat(symbolize): Bazel build system define HAVE_SYMBOLIZE #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 64.04% 64.06% +0.02%
==========================================
Files 20 20
Lines 2578 2580 +2
Branches 898 907 +9
==========================================
+ Hits 1651 1653 +2
- Misses 662 663 +1
+ Partials 265 264 -1 |
sergiud
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Thanks for the PR. Bazel part is looking good. I have just a remark regarding the comment: there is no strict rule for how features should be detected. In this specific instance, however, we prefer the use of the build system for consistency and maintainability reasons.
drigz
approved these changes
Aug 2, 2024
Symbolization support on Linux and BSD requires link.h which is usually provided by the GNU C Library (glibc). Assume the header to be present at all times by unconditionally defining HAVE_SYMBOLIZE on the corresponding platforms.
sergiud
force-pushed
the
dev/shuaizhang/bazel-define-have-symbolize
branch
from
40d47d8 to
f0f7d3c
Compare
sergiud
approved these changes
Aug 2, 2024
sergiud
pushed a commit
that referenced
this pull request
Aug 2, 2024
Symbolization support on Linux and BSD requires link.h which is usually provided by the GNU C Library (glibc). Assume the header to be present at all times by unconditionally defining HAVE_SYMBOLIZE on the corresponding platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link.his usually provided by glibc. Current implementation of symbolize can work onlink.h. Enhance the symbolize detection logic to supportlink.hby defining HAVE_SYMBOLIZE in bazel build description file.The choice of altering bazel build file is for the following reasons
This PR close #1084, supersede #1085 and #1114. It also fixes #1111.