Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework public header structure #1012

Merged
merged 1 commit into from
Dec 30, 2023
Merged

rework public header structure #1012

merged 1 commit into from
Dec 30, 2023

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 30, 2023

Promote generated headers to regular headers. This enables direct editing of corresponding files and running automatic source code formatting and static analysis tools, such as clang-format and clang-tidy on the whole project which previously was not straightforward.

cc @drigz

@sergiud sergiud added this to the 0.7 milestone Dec 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (80d7fa3) 64.78% compared to head (ecef9c8) 64.81%.

Files Patch % Lines
src/glog/logging.h 83.87% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   64.78%   64.81%   +0.03%     
==========================================
  Files          19       19              
  Lines        3334     3334              
  Branches     1128     1128              
==========================================
+ Hits         2160     2161       +1     
  Misses        741      741              
+ Partials      433      432       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud force-pushed the no-configure branch 2 times, most recently from 3b278fe to ca803b6 Compare December 30, 2023 17:25
Promote generated headers to regular headers. This enables direct
editing of corresponding files and running automatic source code
formatting and static analysis tools, such as clang-format and
clang-tidy on the whole project which previously was not
straightforward.
@sergiud sergiud merged commit e3f5398 into master Dec 30, 2023
268 checks passed
@sergiud sergiud deleted the no-configure branch December 30, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants