Skip to content

Commit

Permalink
xcode
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiud committed Oct 8, 2023
1 parent 615966e commit 0887824
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 14 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
matrix:
std: [14, 17, 20, 23]
include:
- generator: Ninja
- generator: Xcode
- build_type: Debug

steps:
Expand All @@ -34,6 +34,7 @@ jobs:
if: matrix.build_type == 'Debug'
run: |
echo 'CXXFLAGS=--coverage' >> $GITHUB_ENV
echo 'LDFLAGS=--coverage' >> $GITHUB_ENV
- name: Configure
shell: bash
Expand All @@ -55,6 +56,7 @@ jobs:
- name: Test
run: |
ctest --test-dir build_${{matrix.build_type}} \
--build-config ${{matrix.build_type}} \
--output-on-failure
- name: Generate Coverage
Expand Down
13 changes: 1 addition & 12 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -612,18 +612,7 @@ if (NOT WITH_FUZZING STREQUAL "none")
endif (NOT WITH_FUZZING STREQUAL "none")

if (BUILD_TESTING)
add_library (glogtest STATIC
$<TARGET_OBJECTS:glog_internal>
)

target_include_directories (glogtest PUBLIC
$<TARGET_PROPERTY:glog,INCLUDE_DIRECTORIES>)
target_compile_definitions (glogtest PUBLIC
$<TARGET_PROPERTY:glog,COMPILE_DEFINITIONS> GLOG_STATIC_DEFINE)
target_link_libraries (glogtest PUBLIC
$<TARGET_PROPERTY:glog,LINK_LIBRARIES>)

set (_GLOG_TEST_LIBS glogtest)
set (_GLOG_TEST_LIBS glog_internal $<TARGET_PROPERTY:glog,LINK_LIBRARIES>)

if (HAVE_LIB_GTEST)
list (APPEND _GLOG_TEST_LIBS GTest::gtest)
Expand Down
2 changes: 1 addition & 1 deletion src/base/commandlineflags.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2008, Google Inc.
// Copyright (c) 2023, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
Expand Down

0 comments on commit 0887824

Please sign in to comment.