NEGRAH GCP fixes #117 #127

NEGRAH-S · 2023-03-31T08:20:27Z

Description

I added few comments from my end that will elaborate more to its understanding as well as I made some changes to indentation.

Changes Made

-Added Comments
-Indentation was done

Checklist

I have read and followed the contributing guidelines.
I have tested my changes thoroughly and they work as expected.
I have added necessary tests for the changes made.
I have updated the documentation to reflect the changes made.
My code follows the project's coding style and standards.
I have added appropriate commit messages and comments for my changes.

Related Issues

issue

Improving Indentation and adding Comments in codebase #117

Additional Notes

This was done with lots of hardwork and diligences any update or ammendment will be highly respected.

google-cla · 2023-03-31T08:20:32Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mshudrak · 2023-03-31T14:23:15Z

Please accept Google CLA before I can review this commit. Adjust commit message to better summarize what you want to change in this PR.

Bhardwaj-Himanshu · 2023-04-05T17:58:48Z

Hi @NEGRAH-S, if you are still unable to figure out why Google-CLA is stopping you from making a change.

Ensure both of your Github-account- @NEGRAH-S and your Local-Git-Machine account-<ne***h@Negrahs-MacBook-Pro.local> are linked with a single Email account.

Also all the commits should be made after first switching your github email to public and then use git config --global user.email "[email protected]" to configure your local repoistory's Email Address.

I hope this helps, cause I just figured it out recently too!
Thanks

ZetaTwo

It's very difficult to follow what changes are where and why. Please squash the commits and separate the whitespace changes from the comment changes so that I can continue the review.

ZetaTwo · 2023-04-06T10:01:20Z

scanner.py

@@ -1,18 +1,19 @@
-#!/usr/bin/env python3
+'''!/usr/bin/env python3


This whole block is incorrect. Please revert

src/gcp_scanner/__init__.py

ZetaTwo · 2023-04-06T10:01:55Z

src/gcp_scanner/__main__.py

@@ -15,8 +15,8 @@
 """The main module of GCP Scanner.

 """
-
+# imprted main module of GCP


Redundant comment

ZetaTwo · 2023-04-06T10:02:08Z

src/gcp_scanner/__main__.py

 from . import scanner

-if __name__ == '__main__':
-  scanner.main()
+if __name__ == "__main__":


Why " instead of '?

ZetaTwo · 2023-04-06T10:03:04Z

src/gcp_scanner/arguments.py


 import argparse
 import logging

+# Defined a function using imported module


Redundant comment

NEGRAH-S · 2023-04-07T11:58:37Z

Please accept Google CLA before I can review this commit. Adjust commit message to better summarize what you want to change in this PR.

mam i have accepten it but don't know why it is showing like that let me check the linked email for both

NEGRAH-S · 2023-04-07T12:01:20Z

@ZetaTwo I am working upon the work told by you and will revert u as soon as possible

Bhardwaj-Himanshu · 2023-04-08T17:08:18Z

Hi @NEGRAH-S, Hope you are doing well mate!
If you are still facing the issue of not being able to fix the "Verification by Google-CLA" issue, I would be happy to help you over that.

NEGRAH-S · 2023-04-10T14:06:08Z

@Bhardwaj-Himanshu hey bro, yeah I would highly admire if you could help in same.

Bhardwaj-Himanshu · 2023-04-11T02:07:55Z

@NEGRAH-S, I am very happy to help brother!
But first I would require some help from your side.
Could you please share your github email id: the one you use to sign in.
and the share me the information which appears in terminal after typing git config --list

Thanks

NEGRAH-S · 2023-04-11T13:34:40Z

@Bhardwaj-Himanshu
My GitHub email- [email protected]
other credential as per my terminal :

Bhardwaj-Himanshu · 2023-04-11T16:28:33Z

Hi @NEGRAH-S,
Thanks for the images,
Go to github settings now-->emails-->"set my email address to private"(below primary email address options)--> set this either to public.

OR

You can change your "GIT-CONFIG USEREMAIL "

This link is a detailed guide, please do check it out-https://help.umbler.com/hc/en-us/articles/360007180671-Turning-your-e-mail-public-on-GitHub

NEGRAH-S · 2023-04-12T13:43:42Z

@Bhardwaj-Himanshu I did as u said then also updated my CLA details it shows updated but still issue is not resolved. can we connect on some private medium for solve the issue.

Bhardwaj-Himanshu · 2023-04-12T15:41:34Z

@NEGRAH-S, Thanks for the feedback.

Now that you have updated your email both on your local machine and github--> I want you to check if your email is marked private or public on github, using the link- https://help.umbler.com/hc/en-us/articles/360007180671-Turning-your-e-mail-public-on-GitHub

Coming on to connecting privately, I would love to do so, so here is my linkedin-https://www.linkedin.com/in/himanshu--bhardwaj/

But let's keep this discussion open and public here on github, so that if I am unable to help, others can look into it and help you.

After opting for public email id on github, I want you to again commit the changes first by making a small change on your local machine, and then upload them into github into another branch or trying using same branch even #117 for your forked repository.

Then create another pull request(could be a test one) and let the checks take place and let me know via a screenshot what happens!

NEGRAH-S · 2023-04-17T13:48:18Z

As discussed with @Bhardwaj-Himanshu I have decided to close this PR and make new with changes mentioned by @ZetaTwo .

Bhardwaj-Himanshu · 2023-04-17T14:22:59Z

@mshudrak, He'll open this pull request again, please don't close this until now.
@NEGRAH-S, do link this issue, while create a new PR.

NEGRAH-S · 2023-04-18T12:33:19Z

@mshudrak, He'll open this pull request again, please don't close this until now.
@NEGRAH-S, do link this issue, while create a new PR.

okh bro I got that will link the issue to my new PR this time.

Bhardwaj-Himanshu · 2023-04-18T12:47:31Z

Also, before changing the lines could you please add "editor.formatOnSaveMode": "modifications",--this line of code to your settings.json file?
What would it do?
-prevent unnecessary introduction of white spaces and blank lines and would only show actual lines modified while doing a commit.
-To do this do Ctrl+Shift+P in vscode --> settings.json in the commmand palette which appears--> open it--> add "editor.formatOnSaveMode": "modifications"--> save

OR you could watch this youtube video for the same, https://www.youtube.com/watch?v=-7t0ewz7-jk

Bhardwaj-Himanshu · 2023-05-03T01:20:47Z

src/gcp_scanner/arguments.py

+        dest="log_file",
+        help="Save logs to the path specified rather than displaying in\
+ console",
+    )


Could you also try removing the unnecessary whitespaces and indentations, these create a great amount of confusion when reviewing the file and some changes could go unnoticed.

Thanks!

Bhardwaj-Himanshu · 2023-05-07T14:55:27Z

@NEGRAH-S Do update this issue with your progress.

Or else @mshudrak @ZetaTwo please close this issue as it's unattended!

NEGRAH-S · 2023-05-08T14:21:30Z

@NEGRAH-S Do update this issue with your progress.

Or else @mshudrak @ZetaTwo please close this issue as it's unattended!

hello @Bhardwaj-Himanshu , I was occupied with some work but I saw someone has made an PR addressing same issue , so I feel this PR can be closed .

Negrah added 10 commits March 30, 2023 21:51

adding comment entry

de602e9

Changed identation and added comment

0d32ef1

Added some comment and made changes to the indentation of code.

e159e8e

Added comments and Made indentation

f8bab6d

Changed indent and Added comment also removed some extra spacing

7af878c

Added comment and alligned indentation

6a36c3d

Added comment and indent allignment

46ab1ba

Added comment and alligned indentation

4d68f31

Changed indent and Added comment also removed some extra spacing

0519f38

added comments

d719049

NEGRAH-S changed the title ~~fixes #issuenumber117~~ NEGRAH GCP fixes #issuenumber117 Mar 31, 2023

NEGRAH-S changed the title ~~NEGRAH GCP fixes #issuenumber117~~ NEGRAH GCP fixes #117 Mar 31, 2023

NEGRAH-S changed the title ~~NEGRAH GCP fixes #117~~ NEGRAH GCP fixes #117 Apr 1, 2023

ZetaTwo requested changes Apr 6, 2023

View reviewed changes

NEGRAH-S closed this Apr 17, 2023

NEGRAH-S reopened this Apr 18, 2023

Bhardwaj-Himanshu reviewed May 3, 2023

View reviewed changes

NEGRAH-S closed this May 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NEGRAH GCP fixes #117 #127

NEGRAH GCP fixes #117 #127

NEGRAH-S commented Mar 31, 2023 •

edited

Loading

google-cla bot commented Mar 31, 2023

mshudrak commented Mar 31, 2023

Bhardwaj-Himanshu commented Apr 5, 2023

ZetaTwo left a comment

ZetaTwo Apr 6, 2023

ZetaTwo Apr 6, 2023

ZetaTwo Apr 6, 2023

ZetaTwo Apr 6, 2023

NEGRAH-S commented Apr 7, 2023

NEGRAH-S commented Apr 7, 2023

Bhardwaj-Himanshu commented Apr 8, 2023

NEGRAH-S commented Apr 10, 2023

Bhardwaj-Himanshu commented Apr 11, 2023 •

edited

Loading

NEGRAH-S commented Apr 11, 2023

Bhardwaj-Himanshu commented Apr 11, 2023

NEGRAH-S commented Apr 12, 2023

Bhardwaj-Himanshu commented Apr 12, 2023 •

edited

Loading

NEGRAH-S commented Apr 17, 2023

Bhardwaj-Himanshu commented Apr 17, 2023

NEGRAH-S commented Apr 18, 2023

Bhardwaj-Himanshu commented Apr 18, 2023

Bhardwaj-Himanshu May 3, 2023

Bhardwaj-Himanshu commented May 7, 2023

NEGRAH-S commented May 8, 2023

		@@ -1,18 +1,19 @@
		#!/usr/bin/env python3
		'''!/usr/bin/env python3

NEGRAH GCP fixes #117 #127

NEGRAH GCP fixes #117 #127

Conversation

NEGRAH-S commented Mar 31, 2023 • edited Loading

Description

Changes Made

Checklist

Related Issues

Additional Notes

google-cla bot commented Mar 31, 2023

mshudrak commented Mar 31, 2023

Bhardwaj-Himanshu commented Apr 5, 2023

ZetaTwo left a comment

Choose a reason for hiding this comment

ZetaTwo Apr 6, 2023

Choose a reason for hiding this comment

ZetaTwo Apr 6, 2023

Choose a reason for hiding this comment

ZetaTwo Apr 6, 2023

Choose a reason for hiding this comment

ZetaTwo Apr 6, 2023

Choose a reason for hiding this comment

NEGRAH-S commented Apr 7, 2023

NEGRAH-S commented Apr 7, 2023

Bhardwaj-Himanshu commented Apr 8, 2023

NEGRAH-S commented Apr 10, 2023

Bhardwaj-Himanshu commented Apr 11, 2023 • edited Loading

NEGRAH-S commented Apr 11, 2023

Bhardwaj-Himanshu commented Apr 11, 2023

NEGRAH-S commented Apr 12, 2023

Bhardwaj-Himanshu commented Apr 12, 2023 • edited Loading

NEGRAH-S commented Apr 17, 2023

Bhardwaj-Himanshu commented Apr 17, 2023

NEGRAH-S commented Apr 18, 2023

Bhardwaj-Himanshu commented Apr 18, 2023

Bhardwaj-Himanshu May 3, 2023

Choose a reason for hiding this comment

Bhardwaj-Himanshu commented May 7, 2023

NEGRAH-S commented May 8, 2023

NEGRAH-S commented Mar 31, 2023 •

edited

Loading

Bhardwaj-Himanshu commented Apr 11, 2023 •

edited

Loading

Bhardwaj-Himanshu commented Apr 12, 2023 •

edited

Loading