Use std::vector instead of the custom InplaceVector for LLVMFuzzerMutate.
#1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/702066944
branch
3 times, most recently
from
485d7fb to
43f3aef
Compare
copybara-service
bot
force-pushed
the
cl/702066944
branch
from
43f3aef to
8d81145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::vectorinstead of the customInplaceVectorfor LLVMFuzzerMutate.The custom
InplaceVectorhas a few issues: Its default constructor (with nullptr backend data) and copy behavior (without copying the underlying data) can be confusing and problematic to the domain implementation; The current container domain does not support dictionary-based mutation onInplaceVector. Using the standardstd::vector(with a bit of copying overhead) seems to be a more economical solution than fixing the aforementioned issues.