-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marhey: Version 1.000 added #5374
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I don't get the STAT table FAIL when I run the latest fontbakery on my computer. |
If the font is a VF it must have a medium instance. The API will generate it automatically, so it has to be in the FVAR table as well. You can either add it where it would be automatically calculated or ask the designer to re-balance the instances weight distribution so it make sense for a medium weight to be there. I know it is annoying, a lot of designers complain, I can link several issues where it is discussed if needed. |
Okay, please link a few |
|
* Marhey Version 1.000 taken from the upstream repo https://github.com/namelatype/Marhey at commit namelatype/Marhey@535eeb5.
Updated Marhey: Version 1.000 added5374a28: [gftools-packager] Marhey: Version 1.000 added
|
31a685a
to
5374a28
Compare
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[23] Marhey[wght].ttf🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[21] Marhey[wght].ttf🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
⚠ WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
31a685a: [gftools-packager] Marhey: Version 1.000 added