Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marhey: Version 1.000 added #5374

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Marhey: Version 1.000 added #5374

merged 2 commits into from
Oct 7, 2022

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Oct 6, 2022

31a685a: [gftools-packager] Marhey: Version 1.000 added

@yanone yanone linked an issue Oct 6, 2022 that may be closed by this pull request
9 tasks
@gf-bot

This comment was marked as outdated.

@yanone
Copy link
Collaborator Author

yanone commented Oct 6, 2022

I don't get the STAT table FAIL when I run the latest fontbakery on my computer.
Otherwise, the font never had a Medium instance. IMO these checks are not supposed to FAIL because of that.

@RosaWagner
Copy link
Contributor

If the font is a VF it must have a medium instance. The API will generate it automatically, so it has to be in the FVAR table as well. You can either add it where it would be automatically calculated or ask the designer to re-balance the instances weight distribution so it make sense for a medium weight to be there. I know it is annoying, a lot of designers complain, I can link several issues where it is discussed if needed.

@RosaWagner RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed - Ready for Review labels Oct 6, 2022
@yanone
Copy link
Collaborator Author

yanone commented Oct 6, 2022

Okay, please link a few

@RosaWagner
Copy link
Contributor

@yanone
Copy link
Collaborator Author

yanone commented Oct 7, 2022

Updated

Marhey: Version 1.000 added


5374a28: [gftools-packager] Marhey: Version 1.000 added

@yanone yanone force-pushed the gftools_packager_ofl_marhey branch from 31a685a to 5374a28 Compare October 7, 2022 13:09
@yanone yanone added - Ready for Review and removed -- Needs Upstream Resolution Upstream fix required before moving forward labels Oct 7, 2022
@gf-bot
Copy link

gf-bot commented Oct 7, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[23] Marhey[wght].ttf
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:257]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret positioning values for these ligature glyphs:

    • f_f
    • f_i

    [code: incomplete-caret-pos-data]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • And f + i [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.74x (1740) [code: bad-hhea-range]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Nur Syamsi is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Bustanul Arifin is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • threedotsdownabovear

    • threedotsdowncenterar

    • threedotsupbelowar

    • twodotsverticalabovear

    • uni0626.medi.calt

    • uni063A_zghainar

    • uni06A2.

    • uni06A2.fina

    • uni06A2.init

    • uni06A2.medi

    • And 4 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/marhey/Marhey[wght].ttf
Dehinted Size 194.0kb
Hinted Size 194.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/marhey [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 13 48 10 155 0
0% 0% 6% 21% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@gf-bot
Copy link

gf-bot commented Oct 7, 2022

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[21] Marhey[wght].ttf
🔥 FAIL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)
  • 🔥 FAIL Family metadata at ofl/marhey failed to parse.
    TRACEBACK:
    28:1 : Message type "google.fonts_public.FamilyProto" has no field named "primary_script". [code: parsing-error]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Light' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:257]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret positioning values for these ligature glyphs:

    • f_f
    • f_i

    [code: incomplete-caret-pos-data]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • And f + i [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.74x (1740) [code: bad-hhea-range]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • threedotsdownabovear

    • threedotsdowncenterar

    • threedotsupbelowar

    • twodotsverticalabovear

    • uni0626.medi.calt

    • uni063A_zghainar

    • uni06A2.

    • uni06A2.fina

    • uni06A2.init

    • uni06A2.medi

    • And 4 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/marhey/Marhey[wght].ttf
Dehinted Size 194.0kb
Hinted Size 194.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/marhey [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 11 89 9 116 0
0% 1% 5% 39% 4% 51% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 97004a8 into main Oct 7, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_marhey branch October 7, 2022 15:04
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I New Font II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Marhey
3 participants