Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commissioner: METADATA.pb updated with all axes #2737

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

RosaWagner
Copy link
Contributor

So this is a great opportunity to clarify the metadata default values (related issue: googlefonts/gf-docs#83 (comment))

  • Default master has weight=100 and METADATA.pd displays weight=400. What should I do ? change it to 100 manually ? or use registry_default_overrides?
  • VOLUME and FLAIR should be added to the axis registry ?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 9, 2020

The axisregistry/ also needs to be updated. We'll need a new .textproto file for each new axis. To gen these, use gftools add-axis.py.

@RosaWagner RosaWagner added the -- Needs manager's opinion from upper level label Oct 14, 2020
@davelab6
Copy link
Member

registry_default_overrides

This is for over-riding values in axis registry; its not related to the glyf table design.

@davelab6
Copy link
Member

Default master has weight=100 and METADATA.pd displays weight=400. What should I do ? change it to 100 manually ? or use registry_default_overrides?

@m4rc1e is going to look into the previous discussion of this, we couldn't find it on a call just now, but any family with this is going to be blocked until this is resolved

@davelab6
Copy link
Member

OK, the issue is here: fonttools/fontbakery#2683

The conclusion was that while the Default glyf master has weight=100, since the wght range covers 400 then its fine for METADATA.pb to have weight=400.

Therefore nothing is needed - no change to 100 manually and no use of registry_default_overrides :)

@davelab6 davelab6 removed the blocked label Oct 19, 2020
@davelab6 davelab6 merged commit 7db54dd into master Oct 19, 2020
@davelab6 davelab6 deleted the commissioner-metadata branch October 19, 2020 15:04
@RosaWagner
Copy link
Contributor Author

This is blocked until we figure out the axis registry / metadata / zip file issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants