[Refactor]: Move members injection optimization into its RequestRepresentation. #4524
+170
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…sentation. I've also added tests for this optimization, since nothing failed when I removed it. This CL moves the logic for a members injection optimization into its corresponding RequestRepresentation (`MembersInjectionRequestRepresentation`). The benefit of this refactor is 1. Consolidates the logic for members injection requests into a single location. 2. Simplifies `ComponentRequestRepresentations` and allows us to share more of the code between members injection and contribution component methods. RELNOTES=N/A PiperOrigin-RevId: 702018277
copybara-service
bot
force-pushed
the
test_700752478
branch
from
a46fdcc
to
369bbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Refactor]: Move members injection optimization into its RequestRepresentation.
I've also added tests for this optimization, since nothing failed when I removed it.
This CL moves the logic for a members injection optimization into its corresponding RequestRepresentation (
MembersInjectionRequestRepresentation).The benefit of this refactor is
ComponentRequestRepresentationsand allows us to share more of the code between members injection and contribution component methods.RELNOTES=N/A