Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Revert #4499 #4512

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[Monitoring] Revert #4499 #4512

merged 1 commit into from
Dec 17, 2024

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Dec 16, 2024 •
edited
Loading

There is a cleaner way to partition ErrorType enums in the criteria proposed (success, retry, failure), by adding the following fields to the uworker output:

  • is_success: boolean
  • is_retryable_error: boolean

Reverting this one.

Part of #4271

@vitorguidi
Revert "[Monitoring] Partition uworker_output.ErrorType conditions in…
a39956d 
…to success, maybe_retry and failure outcomes (#4499)"

This reverts commit d3d1b76.
jonathanmetzman
jonathanmetzman approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@vitorguidi vitorguidi merged commit f9d516c into master Dec 17, 2024
7 checks passed
@vitorguidi vitorguidi deleted the chore/revert-4499 branch December 17, 2024 03:21
@vitorguidi vitorguidi changed the title Revert #4499 [Monitoring] Revert #4499 Dec 17, 2024
vitorguidi added a commit that referenced this pull request Dec 17, 2024
@vitorguidi
Revert "Revert #4499 (#4512)"
38c603c 
This reverts commit f9d516c.
jonathanmetzman pushed a commit that referenced this pull request Dec 20, 2024
@vitorguidi @jonathanmetzman
Revert #4499 (#4512)
c412e33 
There is a clear way to partition ErrorType enums in the criteria
proposed, reverting this one.

Part of #4271
jonathanmetzman added a commit that referenced this pull request Dec 20, 2024
@jonathanmetzman @vitorguidi
Revert #4499 (#4512) (#4534)
3201444 
There is a clear way to partition ErrorType enums in the criteria
proposed, reverting this one.

Part of #4271

Co-authored-by: Vitor Guidi <[email protected]>
vitorguidi added a commit that referenced this pull request Dec 27, 2024
@vitorguidi
Revert #4499 (#4512)
3997898 
There is a clear way to partition ErrorType enums in the criteria
proposed, reverting this one.

Part of #4271
@vitorguidi vitorguidi mentioned this pull request Dec 27, 2024
Merged
vitorguidi added a commit that referenced this pull request Dec 27, 2024
@vitorguidi
Merge remainder monitoring PRs to oss fuzz (#4563)
246122f 
This merges #4512 , #4516 , #4547 , #4497,  #4560 and #4561
jonathanmetzman pushed a commit that referenced this pull request Jan 8, 2025
@vitorguidi @jonathanmetzman
Revert #4499 (#4512)
70b2fd3 
There is a clear way to partition ErrorType enums in the criteria
proposed, reverting this one.

Part of #4271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorguidi @jonathanmetzman