-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Create a dashboard for overall clusterfuzz health #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
changed the title
[WIP] [Monitoring] Create a dashboard for overall clusterfuzz health
[Monitoring] Create a dashboard for overall clusterfuzz health
Dec 13, 2024
vitorguidi
requested review from
letitz,
alhijazi,
jonathanmetzman and
oliverchang
December 13, 2024 03:09
…estcase count by status
jonathanmetzman
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1ing this on what I saw in person in Australia.
oliverchang
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome!
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
alhijazi
reviewed
Dec 20, 2024
vitorguidi
added a commit
that referenced
this pull request
Dec 26, 2024
vitorguidi
added a commit
that referenced
this pull request
Dec 26, 2024
This brings back #4497 . The issue was that, in promql definitions, the '{}' characters were lacking a double escape (\\\\{ and \\\\}). Also, the only parameter to the terraform object should be dashboard_json. Testing: terraform validate ![image](https://github.com/user-attachments/assets/f67434d0-c8e4-4bc0-be38-27188c98ea49) Part of #4271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a final step for the monitoring project, this PR creates a dashboard for overall system health.
The reasoning behind it is to have:
These are sufficient to apply the RED methodology (rate, error and duration), provide high level metrics we can alert on, and aid in troubleshooting outages with a well defined methodology.
There were two options to commit this to version control: terraform, or butler definitions. The first was chosen, since it is the preffered long term solution, and it is also simpler to implement, since it supports copy pasting the JSON definition from GCP.
Attention points
This should be automatically imported from main.tf, so it (should be) sufficient to just place the .tf file in the same folder, and have butler deploy handle the terraform apply step.
How to review
Head over to go/cf-chrome-health-beta, internally. It is not expected that the actual dashboard definition is reviewed, it is just a dump of what was manually created in GCP.
Part of #4271