Skip to content

Commit

Permalink
Temporarily stop using pools to sign URLs (#4430)
Browse files Browse the repository at this point in the history
It may be causing hangs.
  • Loading branch information
jonathanmetzman authored Nov 25, 2024
1 parent 58193a9 commit f7a2037
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/clusterfuzz/_internal/google_cloud_utils/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -1361,8 +1361,7 @@ def sign_urls_for_existing_files(urls,
include_delete_urls) -> List[Tuple[str, str]]:
logs.info('Signing URLs for existing files.')
args = ((url, include_delete_urls) for url in urls)
with concurrency.make_pool(cpu_bound=True, max_pool_size=2) as pool:
result = pool.map(_sign_urls_for_existing_file, args)
result = list(map(_sign_urls_for_existing_file, args))
logs.info('Done signing URLs for existing files.')
return result

Expand Down Expand Up @@ -1397,8 +1396,6 @@ def get_arbitrary_signed_upload_urls(remote_directory: str,

urls = (f'{base_path}-{idx}' for idx in range(num_uploads))
logs.info('Signing URLs for arbitrary uploads.')
with concurrency.make_pool(
_POOL_SIZE, cpu_bound=True, max_pool_size=2) as pool:
result = list(pool.map(get_signed_upload_url, urls))
result = list(map(get_signed_upload_url, urls))
logs.info('Done signing URLs for arbitrary uploads.')
return result

0 comments on commit f7a2037

Please sign in to comment.