Refactor to distinguish logic calling CreateCVD HO API #391
+43
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0405ysj
requested review from
jemoreira,
ser-io,
jmacnak,
rmuthiah,
adelva1984 and
Databean
as code owners
0405ysj
requested review from
ikicha and
k311093
and removed request for
adelva1984,
rmuthiah,
Databean and
jmacnak
|
can you provide the context for this? |
|
This change is for supporting cloning host without upload artifacts for many times, but currently not sure to land this PR due to the comments in the pending design. Let me make this PR as draft again. |
ser-io
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Please read go/tott/703. This refactoring is not helpful as we don't have a clear abstraction yet for creating devices in different ways. Let's not constrain the different create flows for now.
Adding hostService hoclient.HostOrchestratorService field to cvdCreator is positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.