Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit the process after the command action is performed. Closes #805 #828

Closed
wants to merge 1 commit into from

Conversation

nilp0inter
Copy link

@nilp0inter nilp0inter commented Mar 18, 2021

This fixes #805.

I had to disable this lint rule which I think does not apply in this particular case. But maybe I am wrong, I am not a JS developer.

  • npm run test succeeds. (With some errors not introduced by this change)
  • npm run lint succeeds. (With some errors not introduced by this change)
  • Appropriate changes to README are included in PR.

@google-cla
Copy link

google-cla bot commented Mar 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nilp0inter
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 18, 2021
@PopGoesTheWza
Copy link
Collaborator

@nilp0inter I do not favor forcing process.exit() because:

  • it is considered bad practice
  • the root cause for delayed exits has not yet been identified

@nilp0inter
Copy link
Author

That's ok. 😊

@nilp0inter nilp0inter closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoiding Ctrl+c exits to every call
2 participants