-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow root checking to be optionally handled #1258
Conversation
Leaving this up to maintainers, seems like not a thing for me to do in a PR. Let me know what docs update you may want for this. |
Thanks for the PR! Is this meant to be enabled at the server level with a flag? |
/gcbrun |
Some context for history: This PR is a workaround for #1255. Solving #1255 is going to require some careful work to ensure that we don't break any existing users. This option is intended to be used by folks who are doing the root checking on the log list level before supplying it to this codebase through the distributor. |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm late to the party but I've left some comments to follow up.
Checklist