Add logical operator short circuiting tests for list and map accesses (…

…#404)

Signed-off-by: Justin King <[email protected]>

tests/simple/testdata/basic.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "basic"
 description: "Basic conformance tests that all implementations should pass."
 section {

tests/simple/testdata/bindings_ext.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "bindings_ext"
 description: "Tests for the bindings extension library."
 section: {

tests/simple/testdata/block_ext.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 # This conformance test relies on the test-only macros cel.block, cel.index,
 # cel.iterVar, and cel.accuVar. These test-only macros allow excercising
 # cel.block without the optimizers being present.

tests/simple/testdata/comparisons.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "comparisons"
 description: "Tests for boolean-valued functions and operators."
 section {

tests/simple/testdata/conversions.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "conversions"
 description: "Tests for type conversions."
 section {

tests/simple/testdata/dynamic.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "dynamic"
 description: "Tests for 'dynamic' proto behavior, including JSON, wrapper, and Any messages."
 section {

tests/simple/testdata/encoders_ext.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "encoders_ext"
 description: "Tests for the encoders extension library."
 section: {

tests/simple/testdata/enums.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "enums"
 description: "Tests for enum types."
 section {

tests/simple/testdata/fields.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "fields"
 description: "Tests for field access in maps."
 section {
@@ -86,6 +89,61 @@ section {
       errors: { message: "no such key" }
     }
   }
+  test {
+    name: "map_no_such_key_or_false"
+    expr: "dyn({0:1,2:2,5:3}[1]) || false"
+    eval_error: {
+      errors: { message: "no such key" }
+    }
+  }
+  test {
+    name: "map_no_such_key_or_true"
+    expr: "dyn({0:1,2:2,5:3}[1]) || true"
+    value: { bool_value: true }
+  }
+  test {
+    name: "map_no_such_key_and_false"
+    expr: "dyn({0:1,2:2,5:3}[1]) && false"
+    value: { bool_value: false }
+  }
+  test {
+    name: "map_no_such_key_and_true"
+    expr: "dyn({0:1,2:2,5:3}[1]) && true"
+    eval_error: {
+      errors: { message: "no such key" }
+    }
+  }
+  test {
+    name: "map_bad_key_type"
+    expr: "{0:1,2:2,5:3}[dyn(b'')]"
+    eval_error: {
+      errors: { message: "no such key" }
+    }
+  }
+  test {
+    name: "map_bad_key_type_or_false"
+    expr: "dyn({0:1,2:2,5:3}[dyn(b'')]) || false"
+    eval_error: {
+      errors: { message: "no such key" }
+    }
+  }
+  test {
+    name: "map_bad_key_type_or_true"
+    expr: "dyn({0:1,2:2,5:3}[dyn(b'')]) || true"
+    value: { bool_value: true }
+  }
+  test {
+    name: "map_bad_key_type_and_false"
+    expr: "dyn({0:1,2:2,5:3}[dyn(b'')]) && false"
+    value: { bool_value: false }
+  }
+  test {
+    name: "map_bad_key_type_and_true"
+    expr: "dyn({0:1,2:2,5:3}[dyn(b'')]) && true"
+    eval_error: {
+      errors: { message: "no such key" }
+    }
+  }
   test {
     name: "map_field_select_no_such_key"
     expr: "x.name"
@@ -117,6 +175,126 @@ section {
       errors: { message:"no such key: 'name'" }
     }
   }
+  test {
+    name: "map_field_select_no_such_key_or_false"
+    expr: "dyn(x.name) || false"
+    type_env: {
+      name: "x",
+      ident: {
+        type: {
+          map_type: {
+            key_type: {primitive: STRING}
+            value_type: {primitive: STRING}
+          }
+        }
+      }
+    }
+    bindings: {
+      key: "x",
+      value: {
+        value: {
+          map_value: {
+            entries {
+              key: { string_value: "holiday" }
+              value: { string_value: "field" }
+            }
+          }
+        }
+      }
+    }
+    eval_error: {
+      errors: { message:"no such key: 'name'" }
+    }
+  }
+  test {
+    name: "map_field_select_no_such_key_or_true"
+    expr: "dyn(x.name) || true"
+    type_env: {
+      name: "x",
+      ident: {
+        type: {
+          map_type: {
+            key_type: {primitive: STRING}
+            value_type: {primitive: STRING}
+          }
+        }
+      }
+    }
+    bindings: {
+      key: "x",
+      value: {
+        value: {
+          map_value: {
+            entries {
+              key: { string_value: "holiday" }
+              value: { string_value: "field" }
+            }
+          }
+        }
+      }
+    }
+    value: { bool_value: true }
+  }
+  test {
+    name: "map_field_select_no_such_key_and_false"
+    expr: "dyn(x.name) && false"
+    type_env: {
+      name: "x",
+      ident: {
+        type: {
+          map_type: {
+            key_type: {primitive: STRING}
+            value_type: {primitive: STRING}
+          }
+        }
+      }
+    }
+    bindings: {
+      key: "x",
+      value: {
+        value: {
+          map_value: {
+            entries {
+              key: { string_value: "holiday" }
+              value: { string_value: "field" }
+            }
+          }
+        }
+      }
+    }
+    value: { bool_value: false }
+  }
+  test {
+    name: "map_field_select_no_such_key_and_true"
+    expr: "dyn(x.name) && true"
+    type_env: {
+      name: "x",
+      ident: {
+        type: {
+          map_type: {
+            key_type: {primitive: STRING}
+            value_type: {primitive: STRING}
+          }
+        }
+      }
+    }
+    bindings: {
+      key: "x",
+      value: {
+        value: {
+          map_value: {
+            entries {
+              key: { string_value: "holiday" }
+              value: { string_value: "field" }
+            }
+          }
+        }
+      }
+    }
+    eval_error: {
+      errors: { message:"no such key: 'name'" }
+    }
+  }
   test {
     name: "map_value_null"
     expr: '{true:null}[true]'

tests/simple/testdata/fp_math.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "fp_math"
 description: "Tests for floating-point math."
 section {

tests/simple/testdata/integer_math.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "integer_math"
 description: "Tests for int and uint math."
 section {

tests/simple/testdata/lists.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "lists"
 description: "Tests for list operations."
 section {
@@ -90,12 +93,67 @@ section {
     value: { string_value: "Ringo" }
   }
   test {
-    name: "range"
+    name: "index_out_of_bounds"
     expr: "[1, 2, 3][3]"
     eval_error {
       errors { message: "invalid_argument" }
     }
   }
+  test {
+    name: "index_out_of_bounds_or_false"
+    expr: "dyn([1, 2, 3][3]) || false"
+    eval_error {
+      errors { message: "invalid_argument" }
+    }
+  }
+  test {
+    name: "index_out_of_bounds_or_true"
+    expr: "dyn([1, 2, 3][3]) || true"
+    value: { bool_value: true }
+  }
+  test {
+    name: "index_out_of_bounds_and_false"
+    expr: "dyn([1, 2, 3][3]) && false"
+    value: { bool_value: false }
+  }
+  test {
+    name: "index_out_of_bounds_and_true"
+    expr: "dyn([1, 2, 3][3]) && true"
+    eval_error {
+      errors { message: "invalid_argument" }
+    }
+  }
+  test {
+    name: "bad_index_type"
+    expr: "[1, 2, 3][dyn('')]"
+    eval_error {
+      errors { message: "invalid_argument" }
+    }
+  }
+  test {
+    name: "bad_index_type_or_false"
+    expr: "dyn([1, 2, 3][dyn('')]) || false"
+    eval_error {
+      errors { message: "invalid_argument" }
+    }
+  }
+  test {
+    name: "bad_index_type_or_true"
+    expr: "dyn([1, 2, 3][dyn('')]) || true"
+    value: { bool_value: true }
+  }
+  test {
+    name: "bad_index_type_and_false"
+    expr: "dyn([1, 2, 3][dyn('')]) && false"
+    value: { bool_value: false }
+  }
+  test {
+    name: "bad_index_type_and_true"
+    expr: "dyn([1, 2, 3][dyn('')]) && true"
+    eval_error {
+      errors { message: "invalid_argument" }
+    }
+  }
 }
 section {
   name: "in"

tests/simple/testdata/logic.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "logic"
 description: "Tests for logical special operators."
 section {

tests/simple/testdata/macros.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "macros"
 description: "Tests for CEL macros."
 section {

tests/simple/testdata/math_ext.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "math_ext"
 description: "Tests for the math extension library."
 section: {

tests/simple/testdata/namespace.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "namespace"
 description: "Uses of qualified identifiers and namespaces."
 section {

tests/simple/testdata/optionals.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "optionals"
 description: "Tests for optionals."
 section: {

tests/simple/testdata/parse.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "parse"
 description: "End-to-end parsing tests."
 section {

tests/simple/testdata/plumbing.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "plumbing"
 description: "Check that the ConformanceService server can accept all arguments and return all responses."
 section {

tests/simple/testdata/proto2.textproto

@@ -1,3 +1,6 @@
+# proto-file: ../../../proto/test/v1/simple.proto
+# proto-message: google.api.expr.test.v1.SimpleTestFile
+
 name: "proto2"
 description: "Protocol buffer version 2 tests.  See notes for the available set of protos for tests."