Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking errors for MSVC #142

Closed
wants to merge 1 commit into from
Closed

Fix linking errors for MSVC #142

wants to merge 1 commit into from

Conversation

chitoge
Copy link
Contributor

@chitoge chitoge commented Oct 18, 2024

This PR fixes recent GitHub Actions build failures for Windows target.

@chitoge
Copy link
Contributor Author

chitoge commented Oct 18, 2024

I verified that the build action succeeded with my own copy of the IDA 8.2 SDK: https://github.com/chitoge/binexport/actions/runs/11406555000/job/31740568206

@chitoge
Copy link
Contributor Author

chitoge commented Oct 18, 2024

For various reasons I can't currently provide release packages. We'll also need to fix the Windows builds here on GitHub (protobuf linking against the wrong std lib) first.

Originally posted by @cblichmann in #50

Since BinDiff uses Abseil and Protobuf from BinExport, I think this PR will also fix the Windows build failure on BinDiff once it is merged.

@cblichmann
Copy link
Member

Oh wow, I was not aware of that setting and was sort of disheartened to look into this, as I remember that mismatching runtimes are a pain to deal with usually.

Thanks! This will be merged after internal review, which should happen Monday/Tuesday (I'm OOO myself).

copybara-service bot pushed a commit that referenced this pull request Oct 18, 2024
--
58c1fde by Chitoge Kirisaki <[email protected]>:

Fix linking errors for MSVC

COPYBARA_INTEGRATE_REVIEW=#142 from chitoge:main 58c1fde
PiperOrigin-RevId: 687334496
Change-Id: I47df247c49e70db6ad7284d96f8bdf392d8ab7fe
@chitoge
Copy link
Contributor Author

chitoge commented Oct 19, 2024

Thanks for the quick update! I've also verified that this PR indeed fixed the BinDiff build on my fork.

It looks like the change has already been pulled onto main, so I'll close this PR.

@chitoge chitoge closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants