Replace lut yaml with table header #7446
Open
+191
−1,891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratham-mcw
force-pushed
the
lut
branch
2 times, most recently
from
e057adc
to
aa72ec7
Compare
dsharletg
reviewed
Nov 8, 2024
test/x8-lut.cc
Outdated
| // Auto-generated file. Do not edit! | ||
| // Specification: test/x8-lut.yaml | ||
| // Generator: tools/generate-lut-test.py | ||
|
|
||
|
|
||
| #include <gtest/gtest.h> | ||
| #include "xnnpack/common.h" | ||
| #include "xnnpack/isa-checks.h" | ||
| #include "xnnpack/lut.h" | ||
| #include "lut-microkernel-tester.h" |
There was a problem hiding this comment.
If this is the only use of this header, just move the contents of it (and any associated .cc files) to be in this file directly.
|
Merge conflicts? |
|
Hi @dsharletg, while making the changes, I encountered an issue and wasn't able to resolve it today. I will revisit this and try to resolve it tomorrow. Thanks |
pratham-mcw
force-pushed
the
lut
branch
3 times, most recently
from
dd99901
to
bf008ab
Compare
Hi @dsharletg, we have resolved the conflicts. |
dsharlet
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.