-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update actions.py #270
base: master
Are you sure you want to change the base?
Update actions.py #270
Conversation
Zergling morphs into Baneling
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This is hard to fix given it's in the c++ api and in various bots. |
Thanks for your reply. I know that changing the name of constants will affect third party programs. Most experts think that beginners use inaccuracy terms to express concepts, For game players, the constant name is inaccuracy. If you think I am a trouble maker, you can ignore my proposal simply. |
I don't know why I receive this email, there must be something wrong.
I just went through the project named pysc2 on github several days ago, so I think that there's some mismatch.
best wishes, and you guys are doing a great job.
ForeverPs
…---Original---
From: "ethan052"<[email protected]>
Date: Fri, Aug 16, 2019 07:40 AM
To: "deepmind/pysc2"<[email protected]>;
Cc: "Subscribed"<[email protected]>;
Subject: Re: [deepmind/pysc2] Update actions.py (#270)
Thanks for your reply.
Programs run with the actual value of constants.
Changing a constant value will affect program behaviors.
I did't ask you to change the actual value of constants.
I know that changing the name of constants will affect third party programs.
However, how do you distinguish an expert and a beginner in a field?
Most experts think that beginners use inaccuracy terms to express concepts,
so some experts do not want to waste time to explain things to beginners.
For game players, the constant name is inaccuracy.
If you think I am a trouble maker, you can ignore my proposal simply.
If you want to make the framework perfect, you can add the correct constants, and the inaccuracy constant name may be kept for compatibility.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Zergling morphs into Baneling