Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions.py #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update actions.py #270

wants to merge 1 commit into from

Conversation

ethan052
Copy link

Zergling morphs into Baneling

Zergling morphs into Baneling
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tewalds
Copy link
Contributor

tewalds commented Aug 15, 2019

This is hard to fix given it's in the c++ api and in various bots.

@ethan052
Copy link
Author

Thanks for your reply.
Programs run with the actual value of constants.
Changing a constant value will affect program behaviors.
I did't ask you to change the actual value of constants.

I know that changing the name of constants will affect third party programs.
However, how do you distinguish an expert and a beginner in a field?

Most experts think that beginners use inaccuracy terms to express concepts,
so some experts do not want to waste time to explain things to beginners.

For game players, the constant name is inaccuracy.

If you think I am a trouble maker, you can ignore my proposal simply.
If you want to make the framework perfect, you can add the correct constants, and the inaccuracy constant name may be kept for compatibility.

@ForeverPs
Copy link

ForeverPs commented Aug 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants