Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update call to psd_inv_cholesky to fix breaking change #71

Merged
merged 9 commits into from
Nov 24, 2023
Merged

Update call to psd_inv_cholesky to fix breaking change #71

merged 9 commits into from
Nov 24, 2023

Conversation

gcassella
Copy link
Contributor

Closes #70

@gcassella
Copy link
Contributor Author

Tests are now failing due to

ferminet/tests/train_test.py:25: in <module>
    from ferminet import train
ferminet/train.py:24: in <module>
    from ferminet import checkpoint
ferminet/checkpoint.py:24: in <module>
    from ferminet import networks
ferminet/networks.py:21: in <module>
    from ferminet import envelopes
ferminet/envelopes.py:21: in <module>
    from ferminet import curvature_tags_and_blocks
ferminet/curvature_tags_and_blocks.py:76: in <module>
    class QmcBlockedDense(kfac_jax.TwoKroneckerFactored):
ferminet/curvature_tags_and_blocks.py:144: in QmcBlockedDense
    exact_powers: set[kfac_jax.utils.Scalar],
E   TypeError: 'type' object is not subscriptable

@gcassella
Copy link
Contributor Author

Tests are still failing because the codebase now uses union type hints (X | Y) which were introduced in Python 3.10, but the test suite runs on python 3.8.

@gcassella
Copy link
Contributor Author

Just to confirm -- tests are now all passing on my local machine w/ Python 3.10

@jsspencer
Copy link
Collaborator

Just to confirm -- tests are now all passing on my local machine w/ Python 3.10

Yeah, we should drop 3.8 and 3.9 in https://github.com/google-deepmind/ferminet/blob/main/.github/workflows/ci-build.yaml and use 3.10 and 3.11 instead.

ferminet/curvature_tags_and_blocks.py Outdated Show resolved Hide resolved
.github/workflows/ci-build.yaml Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit 6eab988 into google-deepmind:main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream breaking change in kfac-jax
2 participants