-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update call to psd_inv_cholesky
to fix breaking change
#71
Update call to psd_inv_cholesky
to fix breaking change
#71
Conversation
Tests are now failing due to ferminet/tests/train_test.py:25: in <module>
from ferminet import train
ferminet/train.py:24: in <module>
from ferminet import checkpoint
ferminet/checkpoint.py:24: in <module>
from ferminet import networks
ferminet/networks.py:21: in <module>
from ferminet import envelopes
ferminet/envelopes.py:21: in <module>
from ferminet import curvature_tags_and_blocks
ferminet/curvature_tags_and_blocks.py:76: in <module>
class QmcBlockedDense(kfac_jax.TwoKroneckerFactored):
ferminet/curvature_tags_and_blocks.py:144: in QmcBlockedDense
exact_powers: set[kfac_jax.utils.Scalar],
E TypeError: 'type' object is not subscriptable |
Tests are still failing because the codebase now uses union type hints ( |
Just to confirm -- tests are now all passing on my local machine w/ Python 3.10 |
Yeah, we should drop 3.8 and 3.9 in https://github.com/google-deepmind/ferminet/blob/main/.github/workflows/ci-build.yaml and use 3.10 and 3.11 instead. |
…lla/ferminet-1 into gcassella/update-kfac-api
Closes #70