-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.17 support #60
Open
Combustible
wants to merge
14
commits into
goncalomb:master
Choose a base branch
from
Combustible:1.17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.17 support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
Upgrade to 1.16
Signed-off-by: Byron Marohn <[email protected]>
Fix namespace on mob attributes
Signed-off-by: Byron Marohn <[email protected]>
Signed-off-by: Byron Marohn <[email protected]>
If anyone needs this binary before this gets merged and officially built, here's a copy with all of those 1.17 and 1.16 changes: https://files.playmonumenta.com/nbteditor-for-mc-1.17-3.3-SNAPSHOT_2021_12_05.jar I'm sure it's still missing some 1.17 mobs and there are some bugs... but it's at least somewhat usable and doesn't die at startup. I'll fix stuff over time as it causes me problems |
Signed-off-by: Byron Marohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point I'm not even sure how to submit a pull request for this since master is way out of date... a 1.16 branch exists but it doesn't really make sense to submit it to that branch...
Only the last commit in this chain is needed for 1.17 support. Because of the many changes in the structure of 1.17, I don't know how this can ever work on multiple different versions.
Fixes #57