Replace forEach with for in publish for performance

goldfire · Mar 2, 2018 · dca21ab · dca21ab
1 parent 94b5c3e
commit dca21ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/democracy.js b/lib/democracy.js
@@ -194,11 +194,13 @@ class Democracy extends EventEmitter {
    */
   publish(channel, msg) {
     // Loop through all nodes and send the message to ones that are subscribed.
-    Object.keys(this._nodes).forEach((id) => {
+    const ids = Object.keys(this._nodes);
+    for (let i = 0; i < ids.length; i += 1) {
+      const id = ids[i];
       if (this._nodes[id] && this._nodes[id].channels.includes(channel)) {
         this.send(channel, msg, id);
       }
-    });
+    }
 
     return this;
   }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "democracy",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Node.js unicast discovery, master-slave elections and pub/sub.",
   "homepage": "https://github.com/goldfire/democracy.js",
   "keywords": [