-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: report SemanticHighlight for format string directives #557
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: ef16c8a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
9db16d1
to
4e2734c
Compare
This PR (HEAD: 4e2734c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
This PR (HEAD: 4788713) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
Message from Alan Donovan: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
This PR (HEAD: b93c7ef) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
Message from xxx Lulu: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Alan Donovan: Patch Set 4: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
02ee413
to
c66e276
Compare
This PR (HEAD: c66e276) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
0676cae
to
f7bbc9d
Compare
This PR (HEAD: f7bbc9d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
Message from xxx Lulu: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Alan Donovan: Patch Set 7: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
This PR (HEAD: f32e84f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
b13ea4a
to
e760106
Compare
This PR (HEAD: e760106) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
This PR (HEAD: bc9a21f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/643138. Important tips:
|
Message from xxx Lulu: Patch Set 9: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Alan Donovan: Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-22T04:29:26Z","revision":"13440db98c52c0a720c0e3c2ea7c727376572024"} Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from xxx Lulu: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from xxx Lulu: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Alan Donovan: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from Alan Donovan: Patch Set 11: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
Message from xxx Lulu: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/643138. |
This CL uses "format" as modifier type for format string directives.
Fixes golang/go#71295