cmd/gomobile: filter out xcrun warnings to get path #84
Conversation
Currently some installations of Xcode and Command Line Tools cause warnings about missing extensions which break parsing of paths returned from `xcrun` that `gomobile` depends on resulting in errors like this: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` This is caused by these warnings returned on `stdout` by `xcrun`: ``` > xcrun --find clang 2022-09-07 14:50:13.907 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore 2022-09-07 14:50:13.908 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore 2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: com.apple.fonts is not accessible. 2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: XTFontStaticRegistry is enabled. /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang ``` Resulting in `gomobile` interpreting the date `2022-09-07` as Clang compiler. Resolves: golang/go#53316 Signed-off-by: Jakub Sokołowski <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This resolves issues with weird `status-go` build errors like: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR to fix this issue permanently has been created but it might take a while before it's merged. Fix PR: golang/mobile#84 Resolves: #13949 Signed-off-by: Jakub Sokołowski <[email protected]>
This resolves issues with weird `status-go` build errors like: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR to fix this issue permanently has been created but it might take a while before it's merged. Fix PR: golang/mobile#84 Resolves: #13949 Signed-off-by: Jakub Sokołowski <[email protected]>
This resolves issues with weird `status-go` build errors like: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR to fix this issue permanently has been created but it might take a while before it's merged. Fix PR: golang/mobile#84 Resolves: #13949 Signed-off-by: Jakub Sokołowski <[email protected]>
This resolves issues with weird `status-go` build errors like: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR to fix this issue permanently has been created but it might take a while before it's merged. Fix PR: golang/mobile#84 Resolves: #13949 Signed-off-by: Jakub Sokołowski <[email protected]>
|
I'd appreciate a review of this fix. It's causing hard to track down errors which are not deterministic and difficult to reproduce. |
|
This PR (HEAD: f20e966) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/432657 to see it. Tip: You can toggle comments from me using the |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
This resolves issues with weird `status-go` build errors like: ``` cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH ``` Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR to fix this issue permanently has been created but it might take a while before it's merged. Fix PR: golang/mobile#84 Resolves: #13949 Signed-off-by: Jakub Sokołowski <[email protected]>
|
It's been 18 days since I accepted the CLA to get this fix into this library. Any chance for a review? |
|
Message from Jakub Sokołowski: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
|
Message from Michael Knyszek: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
|
Message from Jakub Sokołowski: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432657. |
|
Hello? Anyone? It's been 8 months. |
|
Hello? |
|
Hello? Anyone? |
Currently some installations of Xcode and Command Line Tools cause warnings about missing extensions which break parsing of paths returned from
xcrunthatgomobiledepends on resulting in errors like this:This is caused by these warnings returned on
stdoutbyxcrun:Resulting in
gomobileinterpreting the date2022-09-07as Clang compiler.Resolves: golang/go#53316