Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gomobile: Use parallel build for frameworks on Apple platforms #74

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
+244 −169
Open

cmd/gomobile: Use parallel build for frameworks on Apple platforms #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dc75976
Add parallel build
imWildCat Dec 22, 2021
4629016
Finish major part
imWildCat Dec 22, 2021
272f055
Embed libs first
imWildCat Dec 22, 2021
e605985
Rollback to merge frameworks
imWildCat Jan 1, 2022
7a4f454
Finish parallel build
imWildCat Jan 1, 2022
7a9d5b0
Remove unused field
imWildCat Jan 1, 2022
ab56776
Recover bind
imWildCat Jan 1, 2022
83860d5
Remove unnecessary logs
imWildCat Jan 1, 2022
0572ebc
Recovert gitignore and go.sum
imWildCat Jan 1, 2022
b4ff384
Add empty line at the end
imWildCat Jan 1, 2022
6e4c23b
Remove unused comment
imWildCat Jan 1, 2022
45c4267
Clean up
imWildCat Jan 1, 2022
1b903c7
Remove build result array
imWildCat Jan 1, 2022
50d954c
Fix build result of merged FAT binary
imWildCat Jan 2, 2022
594b595
address review feedbacks
imWildCat Jan 20, 2022
6d124e1
simplify slice append case
imWildCat Jan 20, 2022
fd0e949
Add parallelism limit
imWildCat Jan 20, 2022
cfbbb6f
Small fix
imWildCat Jan 21, 2022
faf4e94
Fix typo
imWildCat Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/gomobile/bind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,13 @@ func runBind(cmd *command) error {
case isAndroidPlatform(targets[0].platform):
return goAndroidBind(gobind, pkgs, targets)
case isApplePlatform(targets[0].platform):
if buildWorkerError := validateBuildWorkers(buildWorkers); buildWorkerError != nil {
return buildWorkerError
}
if !xcodeAvailable() {
return fmt.Errorf("-target=%q requires Xcode", buildTarget)
}
return goAppleBind(gobind, pkgs, targets)
return goAppleBind(gobind, pkgs, targets, buildWorkers)
default:
return fmt.Errorf(`invalid -target=%q`, buildTarget)
}
Expand Down Expand Up @@ -321,3 +324,11 @@ func areGoModulesUsed() (bool, error) {
}
return true, nil
}

func validateBuildWorkers(workers int) error {
if workers < 1 {
return fmt.Errorf("invalid workers %d: must be >= 1", workers)
} else {
return nil
}
}
Loading