Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSA PSS FIPS tests #233

Draft
wants to merge 3 commits into
base: v2
Choose a base branch
from
+20 −14
Draft

Add RSA PSS FIPS tests #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58e1983
add RSA PSS FIPS tests
qmuntal Dec 11, 2024
5fcb8d0
fix TestRSASignVerifyRSAPSS
qmuntal Dec 12, 2024
2d692d2
fix TestRSASignVerifyRSAPSS
qmuntal Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions rsa_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,33 +257,39 @@ func TestRSASignVerifyRSAPSS(t *testing.T) {
// Test cases taken from
// https://github.com/golang/go/blob/54182ff54a687272dd7632c3a963e036ce03cb7c/src/crypto/rsa/pss_test.go#L200.
const keyBits = 2048
sha256 := openssl.NewSHA256()
var saltLengthCombinations = []struct {
signSaltLength, verifySaltLength int
good bool
good, fipsGood bool
}{
{rsa.PSSSaltLengthAuto, rsa.PSSSaltLengthAuto, true},
{rsa.PSSSaltLengthEqualsHash, rsa.PSSSaltLengthAuto, true},
{rsa.PSSSaltLengthEqualsHash, rsa.PSSSaltLengthEqualsHash, true},
{rsa.PSSSaltLengthEqualsHash, 8, false},
{rsa.PSSSaltLengthAuto, rsa.PSSSaltLengthEqualsHash, false},
{8, 8, true},
{rsa.PSSSaltLengthAuto, keyBits/8 - 2 - 32, true}, // simulate Go PSSSaltLengthAuto algorithm (32 = sha256 size)
{rsa.PSSSaltLengthAuto, 20, false},
{rsa.PSSSaltLengthAuto, -2, false},
{rsa.PSSSaltLengthAuto, rsa.PSSSaltLengthAuto, true, true},
{rsa.PSSSaltLengthEqualsHash, rsa.PSSSaltLengthAuto, true, true},
{rsa.PSSSaltLengthEqualsHash, rsa.PSSSaltLengthEqualsHash, true, true},
{rsa.PSSSaltLengthEqualsHash, 8, false, false},
{rsa.PSSSaltLengthAuto, rsa.PSSSaltLengthEqualsHash, false, false},
{8, 8, true, true},
// In FIPS mode, PSSSaltLengthAuto is capped at PSSSaltLengthEqualsHash.
{rsa.PSSSaltLengthAuto, rsa.PSSSaltLengthEqualsHash, false, true},
{rsa.PSSSaltLengthAuto, keyBits/8 - 2 - sha256.Size(), true, false}, // simulate Go PSSSaltLengthAuto algorithm
{rsa.PSSSaltLengthAuto, sha256.Size(), false, true},
{rsa.PSSSaltLengthAuto, -2, false, false},
}
sha256 := openssl.NewSHA256()
priv, pub := newRSAKey(t, keyBits)
sha256.Write([]byte("testing"))
hashed := sha256.Sum(nil)
for i, test := range saltLengthCombinations {
signed, err := openssl.SignRSAPSS(priv, crypto.SHA256, hashed, test.signSaltLength)
if err != nil {
t.Errorf("#%d: error while signing: %s", i, err)
t.Errorf("#%d: error while signing: %v", i, err)
continue
}
err = openssl.VerifyRSAPSS(pub, crypto.SHA256, hashed, signed, test.verifySaltLength)
if (err == nil) != test.good {
t.Errorf("#%d: bad result, wanted: %t, got: %s", i, test.good, err)
good := test.good
if openssl.FIPS() {
good = test.fipsGood
}
if (err == nil) != good {
t.Errorf("#%d: bad result, wanted: %t, got: %v", i, good, err)
}
}
}
Expand Down
Loading