Protect GO_EVP_CIPHER_CTX_PTR with sync.Mutex #145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See golang-fips/go#187 for details on why this is necessary. Protecting these with a mutex is a brute-force approach and presumably has negative performance implications, another option could be to go back to creating a
GO_EVP_CIPHER_CTX_PTR
within each encrypt/decrypt operation instead of caching the context.