Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go1.20-support] Stop using deprecated EC functions for ECDSA #143

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

ueno
Copy link
Collaborator

@ueno ueno commented Apr 11, 2024

This backports #58 to the go1.20-support branch, to address golang-fips/go#177.

ueno added 3 commits April 11, 2024 14:51
For creating and verifying ECDSA signatures in a pre-hashed manner, we
used the legacy ECDSA_sign and ECDSA_verify functions, which bypass
the system-wide restriction on ECDSA.

This switches to using our _goboringcrypto_EVP_{sign,verify}_raw,
which internally use EVP_PKEY_ functions.

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno requested a review from dbenoit17 April 11, 2024 05:55
@ueno ueno requested a review from derekparker April 25, 2024 15:04
Copy link
Contributor

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueno ueno merged commit a10e615 into golang-fips:go1.20-support Apr 26, 2024
ueno added a commit to ueno/openssl-fips that referenced this pull request Jul 4, 2024
This was missing in the previous port in:
golang-fips#143

Signed-off-by: Daiki Ueno <[email protected]>
dbenoit17 pushed a commit that referenced this pull request Jul 8, 2024
This was missing in the previous port in:
#143

Signed-off-by: Daiki Ueno <[email protected]>
archanaravindar added a commit to archanaravindar/golang-fips that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants