Add support for crypto/dsa #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we care, given DSA is now legacy and unapproved for most usecases? |
Unfortunately, with Microsoft Go we need to implement some legacy algorithms using CNG/OpenSSL because of how Microsoft's internal crypto policy and our fork's high compatibility goals interact. We don't think that this is something every fork needs to do, but we need this support in the library for our own fork. It isn't a top priority for us at the moment, but it's something we currently do think we need to get done eventually. /cc @gdams |
qmuntal
requested review from
ueno,
karianna,
derekparker,
alexsaezm,
simo5,
dagood,
gdams and
dbenoit17
karianna
reviewed
Sep 2, 2024
Co-authored-by: Martijn Verburg <[email protected]>
karianna
approved these changes
Sep 3, 2024
derekparker
requested changes
Sep 3, 2024
|
@ueno would be great to have your eyes on this as well. |
dagood
reviewed
Sep 4, 2024
Co-authored-by: Davis Goodin <[email protected]>
dagood
approved these changes
Sep 5, 2024
Co-authored-by: Davis Goodin <[email protected]>
dagood
requested changes
Sep 10, 2024
dagood
approved these changes
Sep 10, 2024
gdams
approved these changes
Sep 11, 2024
ueno
approved these changes
Sep 11, 2024
| return evpSign(priv.withKey, 0, 0, 0, hash) | ||
| } | ||
|
|
||
| // VerifyDSA verifiessig using the public key, pub. |
|
@derekparker Can we get a re-review when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary functions to support crypto/dsa.