Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display line numbers on the main window only #1752

Closed
wants to merge 1 commit into from
Closed

Display line numbers on the main window only #1752

wants to merge 1 commit into from

Conversation

joelim-work
Copy link
Collaborator

Related issues:


Currently the number and relativenumber options display line numbers on all windows. This is in contrast to other file managers like ranger and joshuto, which display line numbers on the main window only.

Warning

This is a breaking change as it modifies the existing behavior of the UI. If anyone is against this, we can instead consider adding an option to toggle this behavior.

@joelim-work joelim-work closed this by deleting the head repository Jul 14, 2024
@masroof-maindak
Copy link

Either I have an enormous skill issue or this change doesn't seem to exist in the main repo?

This is at the relevant commit's hash:
2024-08-08_05:33:28
2024-08-08_05:33:56

And this is when I open the commit history normally.
2024-08-08_05:34:07

I've patched it in manually for now but a proper merge (if one is needed) would be much obliged.

@joelim-work
Copy link
Collaborator Author

Not a skill issue, actually I ended up deleting my fork to test something else and then forgot that any existing PRs would be closed.

Another thing I didn't realize before, but I was thinking it makes sense to display numbers in the parent directory as well. It would be useful for commands like moving up/down in the parent directory. A simplified configuration example would be something like: this:

cmd move-parent &{{
    lf -remote "send $id :updir; push ${lf_count}${1}"
    lf -remote "send $id open"
}}

map J move-parent j
map K move-parent k

@masroof-maindak
Copy link

Hmm, I see your point, but I don't think it's useful to have that much fine-grained control.

For instance, my only use case for the move-parent command is scanning through directories' contents at a glance.

Shall we make an issue to discuss this?

@joelim-work
Copy link
Collaborator Author

That's OK, I reopened #1751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main Column Line Numbers Only
2 participants