Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose information about registries as metrics #21144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adberger
Copy link

@adberger adberger commented Nov 6, 2024

Comprehensive Summary of your change

With this change all registries are exposed as metrics in the harbor-exporter component.

This looks like this:

# HELP harbor_registry_info Information about the registry
# TYPE harbor_registry_info gauge
harbor_registry_info{description="",insecure="false",name="dockerhub",status="healthy",type="docker-hub",url="https://hub.docker.com"} 1

Issue being fixed

Fixes #17531 partially

Website update

goharbor/website#591

Dislaimer

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@adberger adberger requested a review from a team as a code owner November 6, 2024 09:32
@MinerYang MinerYang added the kind/requirement New feature or idea on top of harbor label Nov 11, 2024
@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (c8c11b4) to head (f655045).
Report is 326 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21144      +/-   ##
==========================================
+ Coverage   45.36%   46.29%   +0.92%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6418     +369     
- Misses       6983     7107     +124     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.29% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/requirement New feature or idea on top of harbor release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more Prometheus metrics
5 participants