im7: Return bytes for GetImageProfile #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfx
requested changes
May 30, 2024
| @@ -132,14 +132,14 @@ func (mw *MagickWand) GetImageArtifacts(pattern string) (artifacts []string) { | |||
| // GetImageProfile Returns the named image profile. | |||
| // | |||
| // name: Name of profile to return: ICC, IPTC, or generic profile. | |||
| func (mw *MagickWand) GetImageProfile(name string) string { | |||
There was a problem hiding this comment.
We shouldn't break the existing API. What if we rename this function to GetImageProfileBytes, and then make a GetImageProfile call GetImageProfileBytes and return a string?
There was a problem hiding this comment.
Thanks for your feedback. I added a new function GetImageProfileBytes() and changed GetImageProfile() back to return a string.
The C.MagickGetImageProfile() function returns a char array but it is not only the name of the profile but the bytes of the actual ICC profile. Add the function GetImageProfileBytes() to return []byte the same way RemoveImageProfile() does it. Keep the existing function GetImageProfile() to return a string to not break the existing API but adjust it to call GetImageProfileBytes() internally.
coderkun
force-pushed
the
get-profile-bytes
branch
from
686e275 to
e7dc169
Compare
|
Thanks for those fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
C.MagickGetImageProfile()function returns a char array but it is not only the name of the profile but the bytes of the actual ICC profile. Therefore, change theGetImageProfile()function to return[]byteinstead ofstringthe same wayRemoveImageProfile()does it.