-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Slim template example #387
Conversation
Changing `| {{embed}}` to `== embed`, because `| {{embed}}` not work.
WalkthroughThe recent update modifies the syntax for embedding content within an HTML file, specifically changing how the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- slim/README.md (1 hunks)
Additional context used
LanguageTool
slim/README.md
[style] ~6-~6: Using many exclamation marks might seem excessive (in this case: 3 exclamation marks for a text that’s 627 characters long)
Context: ...ub/v/tag/gofiber/template?filter=slim*) ![Security](https://github.com/gofiber/te...
Markdownlint
slim/README.md
47-47: Column: 1
Hard tabs
49-49: Column: 1
Hard tabs
50-50: Column: 1
Hard tabs
52-52: Column: 1
Hard tabs
56-56: Column: 1
Hard tabs
57-57: Column: 1
Hard tabs
59-59: Column: 1
Hard tabs
60-60: Column: 1
Hard tabs
61-61: Column: 1
Hard tabs
63-63: Column: 1
Hard tabs
64-64: Column: 1
Hard tabs
65-65: Column: 1
Hard tabs
66-66: Column: 1
Hard tabs
68-68: Column: 1
Hard tabs
69-69: Column: 1
Hard tabs
70-70: Column: 1
Hard tabs
71-71: Column: 1
Hard tabs
72-72: Column: 1
Hard tabs
73-73: Column: 1
Hard tabs
75-75: Column: 1
Hard tabs
76-76: Column: 1
Hard tabs
77-77: Column: 1
Hard tabs
78-78: Column: 1
Hard tabs
79-79: Column: 1
Hard tabs
80-80: Column: 1
Hard tabs
82-82: Column: 1
Hard tabs
17-17: null
Fenced code blocks should be surrounded by blank lines
23-23: null
Fenced code blocks should be surrounded by blank lines
25-25: null
Fenced code blocks should be surrounded by blank lines
27-27: null
Fenced code blocks should be surrounded by blank lines
29-29: null
Fenced code blocks should be surrounded by blank lines
31-31: null
Fenced code blocks should be surrounded by blank lines
33-33: null
Fenced code blocks should be surrounded by blank lines
Additional comments not posted (1)
slim/README.md (1)
40-40
: Change in embedding syntax needs clarification.The change from
| {{embed}}
to== embed
is significant. Please ensure that this syntax is supported by the Slim template engine as intended. If possible, provide a reference to the documentation or commit that introduced this syntax change.
thx, you are right we use it like this in our tests |
Changing
| {{embed}}
to== embed
, because| {{embed}}
not work.Summary by CodeRabbit