Skip to content

Commit

Permalink
refactor: Rename "ClientNew" Function to "New" (#2896)
Browse files Browse the repository at this point in the history
Co-authored-by: Juan Calderon-Perez <[email protected]>
  • Loading branch information
sixcolors and gaby authored Mar 7, 2024
1 parent 370cc8b commit 3b982aa
Show file tree
Hide file tree
Showing 8 changed files with 145 additions and 145 deletions.
6 changes: 3 additions & 3 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,11 @@ var (

// init acquire a default client.
func init() {
defaultClient = NewClient()
defaultClient = New()
}

// NewClient creates and returns a new Client object.
func NewClient() *Client {
// New creates and returns a new Client object.
func New() *Client {
// FOllOW-UP performance optimization
// trie to use a pool to reduce the cost of memory allocation
// for the fiber client and the fasthttp client
Expand Down
Loading

1 comment on commit 3b982aa

@ReneWerner87
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3b982aa Previous: d2b19e2 Ratio
Benchmark_Middleware_Favicon 207.9 ns/op 12 B/op 4 allocs/op 90.01 ns/op 3 B/op 1 allocs/op 2.31

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.