Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_rpm() on wheel which has steering #101664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix get_rpm() on wheel which has steering #101664

wants to merge 1 commit into from
+9 −1

Conversation

drakeerv
Copy link

This fixes #101646. There are still some issues with VehicleBody3D but this fixes the problem in the issue.

@drakeerv drakeerv requested review from a team as code owners January 17, 2025 04:01
@Chaosus Chaosus added this to the 4.4 milestone Jan 17, 2025
@fire
Copy link
Member

fire commented Jan 17, 2025 •
edited
Loading

Test plan

Download https://github.com/user-attachments/files/18447812/vehicle-bug.zip

Todo: Test the bug recreation steps.

  1. Create a VehicleBody3D
  2. Create a VehicleWheel3D as a child
  3. Spin up the wheel (engine_force or with friction against the ground)
  4. Turn the wheel with steering on the VehicleBody3D
  5. Call get_rpm() on the VehicleWheel3D which now gives the wrong rpm

@fire fire modified the milestones: 4.4, 4.5 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:physics topic:3d
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

get_rpm() on VehicleWheel3D is calculated incorrectly
3 participants
@drakeerv @fire @Chaosus