Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta link to open script editor from script doc #100868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcvonz
Copy link

@pcvonz pcvonz commented Dec 28, 2024

Link to feature request

Screencast.From.2024-12-27.18-59-56.mp4

@pcvonz pcvonz force-pushed the add-link-to-local-script-from-doc branch 2 times, most recently from ab4a29e to ff8d793 Compare December 28, 2024 02:57
@Repiteo Repiteo added this to the 4.x milestone Dec 28, 2024
@Repiteo Repiteo requested a review from KoBeWi December 28, 2024 04:11
@dalexeev
Copy link
Member

I would suggest moving the icon before the text, to be consistent with most icons in the built-in help (except external links).

Or maybe not use an icon at all, but add text like Script: res://script.gd, where the path is a link. This would be more informative, since it doesn't require you to click the link to see the path.

Also see #100803, which adds a resource link handler too.

@Lazy-Rabbit-2001
Copy link
Contributor

Lazy-Rabbit-2001 commented Dec 28, 2024

A very nice enhancement, and now we have the following entrances to a script from places out of the script editor:

  1. Clicking the script icon at the right side of a node in the scene tree editor
  2. Clicking the script icon at the right side of a type in a create dialog (another pr to be merged soon)
  3. This pr, from a doc

@pcvonz pcvonz force-pushed the add-link-to-local-script-from-doc branch from ff8d793 to f3fa420 Compare December 28, 2024 20:39
@dalexeev dalexeev self-requested a review January 3, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants