Add a 3D tonemapping and color correction demo #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
huwpascoe
suggested changes
Sep 14, 2024
3d/tonemap_color_correction/neutral_luts/3d/create_neutral_3d_luts.gd
Outdated
Show resolved
Hide resolved
Calinou
force-pushed
the
add-color-correction-demo
branch
from
be912cf to
0537563
Compare
Calinou
force-pushed
the
add-color-correction-demo
branch
from
22c8b46 to
a0d6a2a
Compare
Calinou
force-pushed
the
add-color-correction-demo
branch
from
a0d6a2a to
9f4307c
Compare
|
I've updated the PR to add AgX support following the merge of godotengine/godot#87260. |
akien-mga
approved these changes
Jan 11, 2025
| ## *visibly* appear rendering, even though the LUT is still sampled. | ||
| ## Lower resolution neutral LUTs such as 17×17×17 and 33×33×33 will still somewhat impact rendering | ||
| ## due to the limitations of bilinear filtering. | ||
| func create_neutral_lut(p_name: String, p_size: int, p_vertical: bool): |
There was a problem hiding this comment.
Suggested change
| func create_neutral_lut(p_name: String, p_size: int, p_vertical: bool): | |
| func create_neutral_lut(name: String, size: int, vertical: bool): |
| # Hide whitepoint if not relevant (Linear tonemapping does not use a whitepoint). | ||
| %Whitepoint.visible = world_environment.environment.tonemap_mode != Environment.TONE_MAPPER_LINEAR and world_environment.environment.tonemap_mode != Environment.TONE_MAPPER_AGX | ||
|
|
||
| func _on_exposure_value_changed(value: float) -> void: |
There was a problem hiding this comment.
Suggested change
| func _on_exposure_value_changed(value: float) -> void: | |
| func _on_exposure_value_changed(value: float) -> void: |
I think you accidentally reverted Calinou#4 ? |
This showcases various tonemapping operators and their interaction with several color correction textures (1D and 3D). A script generating neutral 3D LUT textures is also included. Co-authored-by: Allen Pestaluky <[email protected]>
Calinou
force-pushed
the
add-color-correction-demo
branch
from
9f4307c to
533cce2
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showcases various tonemapping operators and their interaction with several color correction textures (1D and 3D).
A script generating neutral 3D LUT textures is also included.
Preview