Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for using classes as reference. #49

Closed

Conversation

astrale-sharp
Copy link
Contributor

#45

@Bromeon
Copy link
Member

Bromeon commented Oct 28, 2021

Hello,

Please submit pull requests only with significant content. Blank sections are not interesting. On the other hand, they make management and review of issues and PRs more complex for us, as it takes time to review, check merge conflicts, etc.

I'll leave this open; please force-push your next changes into this PR and do not open yet another one.
Thanks for the understanding!

@jacobsky
Copy link
Contributor

As this PR doesn't appear to add anything yet, I am going to go ahead and close this for the time being. Perhaps once #50 is completed, we can either reopen this PR once there's a little more progress or create a new PR all together.

@jacobsky jacobsky closed this Oct 29, 2021
@astrale-sharp astrale-sharp deleted the use-class-as-ref branch November 2, 2021 12:27
@astrale-sharp astrale-sharp changed the title Adds another (blank) entry in faq/code.md Tutorial for using classes as reference. Nov 3, 2021
@astrale-sharp
Copy link
Contributor Author

astrale-sharp commented Nov 3, 2021

I'd like to use this PR to work on #45, can it be reopen (as draft ) if thats okay @Bromeon .

@Bromeon
Copy link
Member

Bromeon commented Nov 3, 2021

Good with me. Since you deleted the branch, I can't reopen it anymore, so you might need to go through the procedure again 😬

@astrale-sharp
Copy link
Contributor Author

oh no ! git has come for its revenge xD

@astrale-sharp
Copy link
Contributor Author

Edit I'm back from hell, the branch is live but its content is not of value yet, i have to wait for the PR to be opened again to force push in there otherwise the PR cant be opened, let me know if this works!

@jacobsky
Copy link
Contributor

jacobsky commented Nov 3, 2021

@astrale-sharp That would be fine with me. Feel free to reopen this PR with the old branch whenever you are ready for another try.

@astrale-sharp
Copy link
Contributor Author

Good! We'll I dont think i have the proper clearance to reopen it myself unfortunately!

@Bromeon
Copy link
Member

Bromeon commented Nov 4, 2021

Try godot-rust/book#47 😬
(push to existing branch)

Honestly, GitHub is weird sometimes. It should be possible to assign a new branch to an existing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants