Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect width on Trendy style button arrow #902

Merged
merged 12 commits into from
Feb 1, 2024

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Jan 17, 2024

As reported in slack, the Trendy design style arrow button width is incorrect and not showing the full arrow on button hover.

Example:
https://wpnux.godaddy.com/v3?template=sommer&language=en_US&style=trendy&country=US

  • Updated the Cypress Github workflow to upload all .mp4 files on a test failure.
  • Fixed the Cypress e2e customizer test race condition.

@EvanHerman EvanHerman added the [Type] Bug Something that is not working as expected label Jan 17, 2024
@EvanHerman EvanHerman self-assigned this Jan 17, 2024
@EvanHerman
Copy link
Contributor Author

@agerard-godaddy I tweaked things a bit and tried to make this work better regardless of font size. It's slightly different but sill works as intended.

@EvanHerman EvanHerman merged commit 72925eb into master Feb 1, 2024
12 checks passed
@EvanHerman EvanHerman deleted the fix/trendy-button-hover-arrow-width branch February 1, 2024 22:55
@EvanHerman EvanHerman added this to the 1.8.8 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants