Remove jQuery Datepicker from Form Block #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafleur-godaddy
requested review from
AnthonyLedesma,
EvanHerman,
jonathanbardo and
jrtashjian
as code owners
|
Download coblocks.zip: https://36518-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2180.zip |
16 tasks
|
Should we style the new date picker to resemble more to the old one? |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jlemay-godaddy
approved these changes
Nov 29, 2021
olafleur-godaddy
removed request for
jonathanbardo,
EvanHerman,
AnthonyLedesma and
jrtashjian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the spirit of axing jQuery from CoBlocks (#1365), I removed the jQuery datepicker from CoBlocks and replaced it with the HTML 5 date object. There are visual changes, that I've outlined below.
Screenshots
Before
After
Types of changes
Visual change (and removing jQuery)
How has this been tested?
Manually
Checklist: