gochain web3 service WIP1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
Sep 23, 2019
jmank88
reviewed
Sep 23, 2019
| ready$: BehaviorSubject<boolean> = new BehaviorSubject<boolean>(null); | ||
| accountBalance: string; | ||
| gochainWeb3: Web3; | ||
| pluginWeb3: Web3; |
There was a problem hiding this comment.
What about naming these callableWeb3 and payableWeb3 or something like that with more meaning?
There was a problem hiding this comment.
@jmank88 pluginWeb3 only available when user uses Metamask or TrustWallet, either private key
There was a problem hiding this comment.
I'm not sure I understand. How does private key work?
I was thinking that 'callable' and 'payable' better express what is required at the call sites, where they don't care about implementation details. ThenpayableWeb3 would only be set when the ability to sign txs is available, whether that is via a plugin like Metamask/TrustWallet, or our own private key handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.