Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 32bit and 64bit Machdep if possible #173

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Sep 24, 2024

The -m32 and -m64 arguments are x86-only, so these have to be optional.
@sim642
Copy link
Member Author

sim642 commented Sep 24, 2024

Somehow opam install can spuriously sometimes fail like

# File "machdep32", line 1, characters 6-7:
# Error: Syntax error

Do modelConfigure and machdepArchConfigure executions with same binary names conflict somehow?

@sim642 sim642 self-assigned this Sep 24, 2024
@sim642 sim642 added this to the 2.0.5 milestone Sep 25, 2024
@michael-schwarz
Copy link
Member

This likely requires some multiarch packages to be present. What happens when these are not present? I think we should be still able to install CIL, even if the compiler is not set up for producing 32bit executables.

@michael-schwarz michael-schwarz self-requested a review September 27, 2024 09:20
@sim642
Copy link
Member Author

sim642 commented Sep 27, 2024

This likely requires some multiarch packages to be present. What happens when these are not present?

These are option-al, so they'll just be None when -m32 or -m64 doesn't work. We already have something similar for generating similar models for Cilly, which also don't work on arm64 because the options are different.

@sim642 sim642 merged commit 98095b4 into develop Oct 2, 2024
56 checks passed
@sim642 sim642 deleted the machdep-arch branch October 2, 2024 08:25
sim642 added a commit to sim642/opam-repository that referenced this pull request Nov 25, 2024
CHANGES:

* Add enumerator attributes (goblint/cil#172).
* Generate 32bit and 64bit `Machdep` if possible (goblint/cil#173).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants